Bump vm_service to 7.4.0 #1445
Merged
Bump vm_service to 7.4.0 #1445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grouma
reviewed
Nov 11, 2021
| @@ -1036,6 +1036,15 @@ ${globalLoadStrategy.loadModuleSnippet}("dart_sdk").developer.invokeExtension( | |||
| Future<Breakpoint> setBreakpointState( | |||
| String isolateId, String breakpointId, bool enable) => | |||
| throw UnimplementedError(); | |||
|
|
|||
| @override | |||
| Future<UriList> lookupPackageUris(String isolateId, List<String> uris) => | |||
There was a problem hiding this comment.
What are these supposed to return? We may be able to implement it fairly easy.
There was a problem hiding this comment.
definitions are here: https://github.com/dart-lang/sdk/blob/main/pkg/vm_service/lib/src/vm_service.dart#L927-L956. I'm only creating this PR because dwds is blocking the DevTools internal roll. Would it be acceptable to file a bug and add it as a TODO here?
grouma
approved these changes
Nov 11, 2021
elliette
pushed a commit
to elliette/webdev
that referenced
this pull request
Nov 23, 2021
* Bump vm_service to 7.4.0 * add todos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.